ShadowySpirits commented on code in PR #6571:
URL: https://github.com/apache/rocketmq/pull/6571#discussion_r1177471593
##########
store/src/main/java/org/apache/rocketmq/store/CommitLog.java:
##########
@@ -815,89 +809,72 @@ public CompletableFuture<PutMessageResult>
asyncPutMessage(final MessageExtBroke
}
}
- topicQueueLock.lock(topicQueueKey);
- try {
+ PutMessageThreadLocal putMessageThreadLocal =
this.putMessageThreadLocal.get();
Review Comment:
Is there a race issue? I notice you use thread local variable out of the
critical region.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
