cameronlee314 commented on a change in pull request #1047: SAMZA-2210: Initial
majority migration for injecting classloader when doing reflection
URL: https://github.com/apache/samza/pull/1047#discussion_r290043337
##########
File path:
samza-azure/src/main/java/org/apache/samza/coordinator/AzureJobCoordinator.java
##########
@@ -298,8 +298,9 @@ private SchedulerStateChangeListener
createLeaderLivenessListener() {
private SystemStreamPartitionGrouper getSystemStreamPartitionGrouper() {
JobConfig jobConfig = new JobConfig(config);
String factoryString = jobConfig.getSystemStreamPartitionGrouperFactory();
- SystemStreamPartitionGrouper grouper = Util.getObj(factoryString,
SystemStreamPartitionGrouperFactory.class)
- .getSystemStreamPartitionGrouper(jobConfig);
+ SystemStreamPartitionGrouper grouper =
Review comment:
The wiring for the actual plugin classloader will come in a separate PR.
This PR is just setting up for that follow-up. For now, this will just continue
to use the "current" classloader.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
