cameronlee314 commented on a change in pull request #1047: SAMZA-2210: Initial
majority migration for injecting classloader when doing reflection
URL: https://github.com/apache/samza/pull/1047#discussion_r290067793
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
##########
@@ -94,7 +95,7 @@
public LocalApplicationRunner(SamzaApplication app, Config config) {
this.appDesc = ApplicationDescriptorUtil.getAppDescriptor(app, config);
isAppModeBatch = new ApplicationConfig(config).getAppMode() ==
ApplicationConfig.ApplicationMode.BATCH;
- coordinationUtils = getCoordinationUtils(config);
+ coordinationUtils = getCoordinationUtils(config,
getClass().getClassLoader());
Review comment:
This will be changed to the plugin classloader later. Although, we might not
have two different classloader variables in here anyways, as we only really
need to build and pass around the plugin one.
I think it will indeed be clearer once the follow-up PRs come out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
