cameronlee314 commented on a change in pull request #1047: SAMZA-2210: Initial
majority migration for injecting classloader when doing reflection
URL: https://github.com/apache/samza/pull/1047#discussion_r290506568
##########
File path:
samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java
##########
@@ -300,7 +300,8 @@ protected void setupSystem() {
String systemFactoryName = log4jSystemConfig.getSystemFactory(systemName)
.orElseThrow(() -> new SamzaException(
"Could not figure out \"" + systemName + "\" system factory for
log4j StreamAppender to use"));
- SystemFactory systemFactory = Util.getObj(systemFactoryName,
SystemFactory.class);
+ SystemFactory systemFactory =
Review comment:
Just to add a little more context:
`StreamAppender` would get loaded by
`Thread.currentThread().getContextClassLoader()`. If the context classloader is
unset (can also disable usage of context classloader in log4j), then it will
fall back to the classloader of the class which is using the logger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
