cameronlee314 commented on a change in pull request #1047: SAMZA-2210: Initial
majority migration for injecting classloader when doing reflection
URL: https://github.com/apache/samza/pull/1047#discussion_r290045060
##########
File path:
samza-core/src/main/java/org/apache/samza/runtime/LocalApplicationRunner.java
##########
@@ -94,7 +95,7 @@
public LocalApplicationRunner(SamzaApplication app, Config config) {
this.appDesc = ApplicationDescriptorUtil.getAppDescriptor(app, config);
isAppModeBatch = new ApplicationConfig(config).getAppMode() ==
ApplicationConfig.ApplicationMode.BATCH;
- coordinationUtils = getCoordinationUtils(config);
+ coordinationUtils = getCoordinationUtils(config,
getClass().getClassLoader());
Review comment:
This is actually the plugin classloader also, since it is used to load a
`CoordinationUtilsFactory`.
Except for the very initial creation of the classloader, Samza code won't
need to deal with framework classloader vs. plugin classloader. That difference
is built into the classloader itself, so there is only one classloader that is
passed around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
