kw2542 commented on a change in pull request #1278: SAMZA-2458: Update
ProcessJobFactory and ThreadJobFactory to load full job config
URL: https://github.com/apache/samza/pull/1278#discussion_r379579249
##########
File path:
samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala
##########
@@ -51,15 +70,11 @@ class ProcessJobFactory extends StreamJobFactory with
Logging {
val coordinatorStreamStore: CoordinatorStreamStore = new
CoordinatorStreamStore(config, new MetricsRegistryMap())
coordinatorStreamStore.init()
- val configFromCoordinatorStream: Config =
CoordinatorStreamUtil.readConfigFromCoordinatorStream(coordinatorStreamStore)
-
val changelogStreamManager = new ChangelogStreamManager(new
NamespaceAwareCoordinatorStreamStore(coordinatorStreamStore,
SetChangelogMapping.TYPE))
-
- val coordinator = JobModelManager(configFromCoordinatorStream,
changelogStreamManager.readPartitionMapping(),
- coordinatorStreamStore, metricsRegistry)
+ val coordinator = JobModelManager(config,
changelogStreamManager.readPartitionMapping(), coordinatorStreamStore,
metricsRegistry)
Review comment:
updated, nice catch, not sure why it was named coordinator before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
