kw2542 commented on a change in pull request #1278: SAMZA-2458: Update
ProcessJobFactory and ThreadJobFactory to load full job config
URL: https://github.com/apache/samza/pull/1278#discussion_r379695518
##########
File path:
samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala
##########
@@ -45,20 +47,36 @@ import scala.collection.mutable
* Creates a new Thread job with the given config
*/
class ThreadJobFactory extends StreamJobFactory with Logging {
- def getJob(config: Config): StreamJob = {
+ def getJob(submissionConfig: Config): StreamJob = {
info("Creating a ThreadJob, which is only meant for debugging.")
+ var config = submissionConfig
+ if (new JobConfig(submissionConfig).getConfigLoaderFactory.isPresent) {
Review comment:
I am planning to simplify and refactor all of them after I introduces beam
related planning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
