cameronlee314 commented on a change in pull request #1278: SAMZA-2458: Update
ProcessJobFactory and ThreadJobFactory to load full job config
URL: https://github.com/apache/samza/pull/1278#discussion_r379694518
##########
File path:
samza-core/src/main/scala/org/apache/samza/job/local/ProcessJobFactory.scala
##########
@@ -87,13 +106,13 @@ class ProcessJobFactory extends StreamJobFactory with
Logging {
val commandBuilder = ReflectionUtil.getObj(commandBuilderClass,
classOf[CommandBuilder])
// JobCoordinator is stopped by ProcessJob when it exits
Review comment:
Could you please update this comment? It looks like it was out-of-date
before you made your changes, but would be nice to clarify it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
