rmatharu commented on a change in pull request #1402:
URL: https://github.com/apache/samza/pull/1402#discussion_r458452942
##########
File path:
samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsManager.java
##########
@@ -93,12 +102,23 @@ public DiagnosticsManager(String jobName,
String hostname,
SystemStream diagnosticSystemStream,
SystemProducer systemProducer,
- Duration terminationDuration, boolean autosizingEnabled) {
+ Duration terminationDuration,
+ boolean autosizingEnabled,
+ String deploymentType,
Review comment:
Should deploymentType and api type be enums, since we defined an enum
for them above?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
