rmatharu commented on a change in pull request #1402:
URL: https://github.com/apache/samza/pull/1402#discussion_r458453999
##########
File path:
samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporterFactory.scala
##########
@@ -124,7 +124,20 @@ class MetricsSnapshotReporterFactory extends
MetricsReporterFactory with Logging
Util.getTaskClassVersion(config),
Util.getSamzaVersion,
Util.getLocalHost.getHostName,
- serde, blacklist)
+ serde,
+ blacklist,
+ Util.getDeploymentType(config),
+ Util.getApiType(config),
+ Util.getContainerCount(config),
+ Util.getContainerMemoryMb(config),
+ Util.getNumCores(config),
+ Util.getThreadPoolSize(config),
+ Util.getHostAffinityEnabled(config),
+ Util.getSspGrouperFactory(config),
+ Util.getContainerRetryCount(config),
+ Util.getContainerRetryWindowMs(config),
+ Util.getMaxConcurrency(config),
+ Util.getMaxJvmHeapMb)
Review comment:
Please maintain the existing ordering of passing in the parameters, then
the serde and then the blacklist.
Similar for MetricsHeader above, where time fields are passed in last.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
