rmatharu commented on a change in pull request #1402:
URL: https://github.com/apache/samza/pull/1402#discussion_r463181587
##########
File path: samza-core/src/main/java/org/apache/samza/util/Util.java
##########
@@ -29,15 +29,23 @@
import java.util.stream.Collectors;
import com.google.common.collect.Lists;
import org.apache.samza.SamzaException;
+import org.apache.samza.application.StreamApplication;
import org.apache.samza.config.ApplicationConfig;
+import org.apache.samza.config.ClusterManagerConfig;
import org.apache.samza.config.Config;
+import org.apache.samza.config.JobConfig;
import org.apache.samza.config.TaskConfig;
+import org.apache.samza.metrics.ApiType;
+import org.apache.samza.metrics.DeploymentType;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
public class Util {
private static final Logger LOG = LoggerFactory.getLogger(Util.class);
+ private static final String YARN_JOB_FACTORY_CLASS =
"org.apache.samza.job.yarn.YarnJobFactory";
+ private static final String BEAM_RUNNER_CLASS =
"org.apache.beam.runners.samza.SamzaRunner";
Review comment:
Is this actually needed given
https://github.com/apache/samza/pull/1185 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
