rmatharu commented on a change in pull request #1402:
URL: https://github.com/apache/samza/pull/1402#discussion_r458453590
##########
File path:
samza-core/src/main/scala/org/apache/samza/diagnostics/DiagnosticsStreamMessage.java
##########
@@ -237,7 +242,13 @@ public static DiagnosticsStreamMessage
convertToDiagnosticsStreamMessage(Metrics
metricsSnapshot.getHeader().getContainerName(),
metricsSnapshot.getHeader().getExecEnvironmentContainerId(),
metricsSnapshot.getHeader().getVersion(),
metricsSnapshot.getHeader().getSamzaVersion(),
metricsSnapshot.getHeader().getHost(),
metricsSnapshot.getHeader().getTime(),
- metricsSnapshot.getHeader().getResetTime());
+ metricsSnapshot.getHeader().getResetTime(),
metricsSnapshot.getHeader().getDeploymentType(),
+ metricsSnapshot.getHeader().getApiType(),
metricsSnapshot.getHeader().getNumContainers(),
+ metricsSnapshot.getHeader().getContainerMemoryMb(),
metricsSnapshot.getHeader().getContainerCpuCores(),
+ metricsSnapshot.getHeader().getContainerThreadPoolSize(),
metricsSnapshot.getHeader().getHostAffinity(),
+ metricsSnapshot.getHeader().getSspGrouper(),
metricsSnapshot.getHeader().getMaxContainerRetryCount(),
+ metricsSnapshot.getHeader().getContainerRetryWindowMs(),
metricsSnapshot.getHeader().getTaskMaxConcurrency(),
+ metricsSnapshot.getHeader().getMaxJvmHeapMb());
Review comment:
Can we add a new separate constructor for DiagnosticsStreamMessage that
takes a metricsHeader as input?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
