prateekm commented on a change in pull request #1408:
URL: https://github.com/apache/samza/pull/1408#discussion_r466710445
##########
File path: samza-api/src/main/java/org/apache/samza/system/SystemFactory.java
##########
@@ -32,4 +32,16 @@
SystemProducer getProducer(String systemName, Config config, MetricsRegistry
registry);
SystemAdmin getAdmin(String systemName, Config config);
+
+ default SystemConsumer getConsumer(String systemName, Config config,
MetricsRegistry registry, String consumerIdPrefix) {
Review comment:
I'm assuming this is intended to be used as part of the Kafka clientId
to figure out who owns the instance?
Maybe consumerLabel. We should add some documentation on what this should be
set to by the caller (e.g., set this to indicate ownership of the client
instance), how this will be used by system implementers (e.g., to identify
consumers in logs, threads and client instances etc., along with other relevant
information like systemName).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
