prateekm commented on a change in pull request #1408:
URL: https://github.com/apache/samza/pull/1408#discussion_r466760235
##########
File path: samza-api/src/main/java/org/apache/samza/system/SystemFactory.java
##########
@@ -32,4 +32,16 @@
SystemProducer getProducer(String systemName, Config config, MetricsRegistry
registry);
SystemAdmin getAdmin(String systemName, Config config);
+
+ default SystemConsumer getConsumer(String systemName, Config config,
MetricsRegistry registry, String consumerIdPrefix) {
Review comment:
@MabelYC what do you mean? I'm suggesting that we add the annotation to
mark them as deprecated (e.g. https://www.baeldung.com/java-deprecated). We
will not remove the older methods. This will mean that when some code calls the
older methods, the author will get build time warnings that the method they're
calling is deprecated, so that they can start using the new (better) method
instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
