MabelYC commented on a change in pull request #1408:
URL: https://github.com/apache/samza/pull/1408#discussion_r466734546
##########
File path: samza-api/src/main/java/org/apache/samza/system/SystemFactory.java
##########
@@ -32,4 +32,16 @@
SystemProducer getProducer(String systemName, Config config, MetricsRegistry
registry);
SystemAdmin getAdmin(String systemName, Config config);
+
+ default SystemConsumer getConsumer(String systemName, Config config,
MetricsRegistry registry, String consumerIdPrefix) {
Review comment:
> Also, let's make this the second parameter after systemName to group
naming related parameters together.
I think change order may not be a good option. We are adding functions to
help make previous ones more flexible, so may be better to keep the order the
same as previous one. And also, systemName is not intended to be a naming
parameter. So i think it may be better to keep it in current order. what do you
think？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
