MabelYC commented on a change in pull request #1408:
URL: https://github.com/apache/samza/pull/1408#discussion_r466726991
##########
File path: samza-api/src/main/java/org/apache/samza/system/SystemFactory.java
##########
@@ -32,4 +32,16 @@
SystemProducer getProducer(String systemName, Config config, MetricsRegistry
registry);
SystemAdmin getAdmin(String systemName, Config config);
+
+ default SystemConsumer getConsumer(String systemName, Config config,
MetricsRegistry registry, String consumerIdPrefix) {
Review comment:
Not sure if it is better. With deprecated, user will still have to
implement them later. Can it work as we expect?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
