PawasChhokra commented on a change in pull request #1455:
URL: https://github.com/apache/samza/pull/1455#discussion_r553061569
##########
File path:
samza-core/src/main/java/org/apache/samza/container/ContainerHeartbeatMonitor.java
##########
@@ -170,4 +212,55 @@ public Thread newThread(Runnable runnable) {
return t;
}
}
+
+ static final class ContainerHeartbeatMetrics {
+ private static final String GROUP = "ContainerHeartbeatMonitor";
+ private static final String HEARTBEAT_DISCOVERY_TIME_MS =
"heartbeat-discovery-time-ms";
+ private static final String HEARTBEAT_ESTABLISHED_FAILURE_COUNT =
"heartbeat-established-failure-count";
+ private static final String HEARTBEAT_ESTABLISHED_WITH_NEW_AM_COUNT =
"heartbeat-established-with-new-am-count";
+ private static final String HEARTBEAT_EXPIRED_COUNT =
"heartbeat-expired-count";
+
+ private final Counter heartbeatEstablishFailureCount;
Review comment:
nit - Change `heartbeatEstablishFailureCount` to
`heartbeatEstablishedFailureCount`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
