mynameborat commented on a change in pull request #1455:
URL: https://github.com/apache/samza/pull/1455#discussion_r553553128
##########
File path:
samza-core/src/main/java/org/apache/samza/container/ContainerHeartbeatMonitor.java
##########
@@ -150,8 +183,17 @@ ContainerHeartbeatClient
createContainerHeartbeatClient(String coordinatorUrl, S
return new ContainerHeartbeatClient(coordinatorUrl, containerExecutionId);
}
+ @VisibleForTesting
+ ContainerHeartbeatMetrics getMetrics() {
+ return metrics;
+ }
+
private void forceExit(String message, int timeout) {
scheduler.schedule(() -> {
+ if (started) {
+ reporters.values().forEach(MetricsReporter::stop);
Review comment:
`onContainerExpired.run` will invoke the stop on the
`ContainerHeartbeatMonitor` which should stop all the reporters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
