mynameborat commented on a change in pull request #1455:
URL: https://github.com/apache/samza/pull/1455#discussion_r553553524
##########
File path:
samza-core/src/main/java/org/apache/samza/container/ContainerHeartbeatMonitor.java
##########
@@ -100,7 +123,7 @@ public void start() {
} catch (Exception e) {
// On exception in re-establish connection with new AM, force exit.
LOG.error("Exception trying to connect with new AM", e);
- forceExit("failure in establishing cconnection with new AM", 0);
+ forceExit("failure in establishing cconnection with new AM",
SHUTDOWN_TIMOUT_MS);
Review comment:
I originally didn't intend to do this and hence the tests don't assert
this. reflecting back, I ended up adding here and also including them in tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
