mynameborat commented on a change in pull request #1455:
URL: https://github.com/apache/samza/pull/1455#discussion_r553527779
##########
File path:
samza-core/src/main/java/org/apache/samza/container/ContainerHeartbeatMonitor.java
##########
@@ -91,6 +113,7 @@ public void start() {
scheduler.scheduleAtFixedRate(() -> {
ContainerHeartbeatResponse response =
containerHeartbeatClient.requestHeartbeat();
if (!response.isAlive()) {
+ metrics.incrementHeartbeatExpiredCount();
Review comment:
yeah. there is no concept of re-establishing the heartbeat prior to AM
HA. but this metric is still useful regardless.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
