[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #2719: [Improve][e2e] add driver-jar to lib

Wed, 14 Sep 2022 19:19:57 -0700 


liugddx commented on code in PR #2719:
URL: 
https://github.com/apache/incubator-seatunnel/pull/2719#discussion_r971456530


##########
seatunnel-plugin-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java:
##########
@@ -107,15 +107,25 @@ public T createPluginInstance(PluginIdentifier 
pluginIdentifier) {
             try {
                 // use current thread classloader to avoid different 
classloader load same class error.
                 this.addURLToClassLoader.accept(classLoader, 
pluginJarPath.get());
+                ClassLoader finalClassLoader = classLoader;

Review Comment:
   
![image](https://user-images.githubusercontent.com/48236177/190297790-2c81d799-a6a5-4558-ba96-6e206b6392c5.png)
   step1 will use dirver class ,and i Transfer the position step1 to step2.it 
will report error again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to