Hisoka-X commented on code in PR #2719:
URL:
https://github.com/apache/incubator-seatunnel/pull/2719#discussion_r971555663
##########
seatunnel-common/src/main/java/org/apache/seatunnel/common/config/Common.java:
##########
@@ -47,6 +52,21 @@ private Common() {
private static boolean STARTER = false;
+ /**
Review Comment:
Please don't add it in here, this `ADD_URL_TO_CLASSLOADER` only work for
flink, spark use default `ADD_URL_TO_CLASSLOADER` in `AbstractPluginDiscovery`.
So this method not 'common'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
