TyrantLucifer commented on code in PR #2719:
URL:
https://github.com/apache/incubator-seatunnel/pull/2719#discussion_r971490959
##########
seatunnel-plugin-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java:
##########
@@ -107,15 +107,25 @@ public T createPluginInstance(PluginIdentifier
pluginIdentifier) {
try {
// use current thread classloader to avoid different
classloader load same class error.
this.addURLToClassLoader.accept(classLoader,
pluginJarPath.get());
+ ClassLoader finalClassLoader = classLoader;
Review Comment:
> Do it in `registerPlugin` method maybe better. At now. `registerPlugin`
only register to flink environment, but not load it into client classpath. You
can call `addURLToClassLoader ` logic in there. And call `registerPlugin` to
load third party jar first, then call Source/SinkExecuteProcessor to load
connector jar.
Aggre with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
