Hisoka-X commented on code in PR #2719:
URL:
https://github.com/apache/incubator-seatunnel/pull/2719#discussion_r971483016
##########
seatunnel-plugin-discovery/src/main/java/org/apache/seatunnel/plugin/discovery/AbstractPluginDiscovery.java:
##########
@@ -107,15 +107,25 @@ public T createPluginInstance(PluginIdentifier
pluginIdentifier) {
try {
// use current thread classloader to avoid different
classloader load same class error.
this.addURLToClassLoader.accept(classLoader,
pluginJarPath.get());
+ ClassLoader finalClassLoader = classLoader;
Review Comment:
You can use `addURLToClassLoader.accept` to load third party jar to
classloader, but not here. `AbstractPluginDiscovery` used for load connector
jar. But it use logic like `addURLToClassLoader` to load connector jar into
current classloader. If you also want use logic like `addURLToClassLoader`, I
think you should create new class like `ThirdPartyJarLoadService`, use same
parameter to receive `addURLToClassLoader`.
PS: `addURLToClassLoader` logic shouldn't repeat, please extract public code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
