zhilinli123 commented on code in PR #7921:
URL: https://github.com/apache/seatunnel/pull/7921#discussion_r1820026971
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSourceReader.java:
##########
@@ -97,6 +101,12 @@ record -> {
}
this.readerContext.signalNoMoreElement();
this.splits.clear();
+ } else if (noMoreSplit
+ && splits.isEmpty()
+ && Boundedness.BOUNDED.equals(readerContext.getBoundedness()))
{
+ log.info("Closed the bounded ClickHouse source");
+ this.readerContext.signalNoMoreElement();
+ this.splits.clear();
}
Review Comment:
> > What if the user uses processing mode to write STREAMING?
>
> Sorry, I don get it. Could you share more details? You meaning set
`job.mode` to `STREAMING`?
```
env {
job.mode = "STREAMING"
parallelism = 2
}
source {
# This is a example source plugin **only for test and demonstrate the
feature source plugin**
Clickhouse {
host = "127.0.0.1:8123"
database = "default"
sql = "select * from students"
username = "default"
password = ""
}
# If you would like to get more information about how to configure
seatunnel and see full list of source plugins,
# please go to
https://seatunnel.apache.org/docs/connector-v2/source/ClickhouseSource
}
sink {
Console {
}
# If you would like to get more information about how to configure
seatunnel and see full list of sink plugins,
# please go to https://seatunnel.apache.org/docs/connector-v2/sink
}
```
So for example in this case the user will never exit the program,
essentially no matter how you configure the read mode clickhouse only supports
batch mode, right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
