Hisoka-X commented on code in PR #7921:
URL: https://github.com/apache/seatunnel/pull/7921#discussion_r1820031238
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSourceReader.java:
##########
@@ -97,6 +101,12 @@ record -> {
}
this.readerContext.signalNoMoreElement();
this.splits.clear();
+ } else if (noMoreSplit
+ && splits.isEmpty()
+ && Boundedness.BOUNDED.equals(readerContext.getBoundedness()))
{
+ log.info("Closed the bounded ClickHouse source");
+ this.readerContext.signalNoMoreElement();
+ this.splits.clear();
}
Review Comment:
If users set to STREAMING, but source only supported BATCH mode. The job
will execute as BATCH mode. It depends on
https://github.com/apache/seatunnel/blob/a8d0d4ce77a1ac9116f93381dfe296d22d8f0e8b/seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSource.java#L160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
