zhilinli123 commented on code in PR #7921:
URL: https://github.com/apache/seatunnel/pull/7921#discussion_r1820033374
##########
seatunnel-connectors-v2/connector-clickhouse/src/main/java/org/apache/seatunnel/connectors/seatunnel/clickhouse/source/ClickhouseSourceReader.java:
##########
@@ -97,6 +101,12 @@ record -> {
}
this.readerContext.signalNoMoreElement();
this.splits.clear();
+ } else if (noMoreSplit
+ && splits.isEmpty()
+ && Boundedness.BOUNDED.equals(readerContext.getBoundedness()))
{
+ log.info("Closed the bounded ClickHouse source");
+ this.readerContext.signalNoMoreElement();
+ this.splits.clear();
}
Review Comment:
Understood, but an extra judgment is a redundant operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
