dybyte commented on code in PR #9234:
URL: https://github.com/apache/seatunnel/pull/9234#discussion_r2083504877
##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/config/MaxcomputeSinkOptions.java:
##########
@@ -46,6 +46,18 @@ public class MaxcomputeSinkOptions extends
MaxcomputeBaseOptions {
public static final Option<String> CUSTOM_SQL =
Options.key("custom_sql").stringType().noDefaultValue().withDescription("custom_sql");
+ public static final Option<String> LOCAL_DATETIME_FORMAT =
+ Options.key("local_datetime_format")
+ .stringType()
+ .defaultValue("yyyy-MM-dd HH:mm:ss")
+ .withDescription("local_datetime_format");
+
+ public static final Option<String> OFFSET_DATETIME_FORMAT =
+ Options.key("offset_datetime_format")
+ .stringType()
+ .defaultValue("yyyy-MM-dd HH:mm:ssXXXXX")
+ .withDescription("offset_datetime_format");
+
Review Comment:
@Hisoka-X
I'm running into CI failures, but I'm having trouble identifying whether
they are caused by my changes.
I ran the failing tests locally and found that:
- Some of them pass on my machine, while others fail.
- I checked out the `main` branch and ran the same tests, and **the same
ones are still failing** there as well.
This makes me wonder if some of the tests might be flaky or already broken
on `main`.
If you have any guidance on how I should approach this or if there's
something I'm missing, I'd really appreciate the help
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
