dybyte commented on code in PR #9234:
URL: https://github.com/apache/seatunnel/pull/9234#discussion_r2103137344
##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/sink/MaxcomputeWriter.java:
##########
@@ -66,6 +69,15 @@ public MaxcomputeWriter(ReadonlyConfig readonlyConfig,
SeaTunnelRowType rowType)
readonlyConfig.get(MaxcomputeSinkOptions.PROJECT),
readonlyConfig.get(MaxcomputeSinkOptions.TABLE_NAME));
}
+ if
(readonlyConfig.getOptional(FormatOptions.DATETIME_FORMAT_VALUE).isPresent()) {
+ this.formatterContext =
+ new FormatterContext(
+
readonlyConfig.get(FormatOptions.DATETIME_FORMAT_VALUE));
+ } else {
+ this.formatterContext =
+ new
FormatterContext(readonlyConfig.get(FormatOptions.DATETIME_FORMAT));
+ }
Review Comment:
Thanks for the detailed suggestions, @Hisoka-X!
I've:
- Renamed *_VALUE options to align with existing names (e.g., DATE_FORMAT)
- Marked previous enum-based options as legacy (e.g., DATE_FORMAT_LEGACY)
- Used the same key for the new string-based option as the legacy one, so we
can switch seamlessly later on
- Removed the format validation logic as suggested
- Introduced default format in format options
Let me know if there's anything else I should adjust!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
