Hisoka-X commented on code in PR #9234:
URL: https://github.com/apache/seatunnel/pull/9234#discussion_r2103852857
##########
seatunnel-connectors-v2/connector-maxcompute/src/test/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/BasicTypeToOdpsTypeTest.java:
##########
@@ -34,9 +37,18 @@
import com.aliyun.odps.data.Record;
import lombok.SneakyThrows;
+import java.sql.Timestamp;
import java.time.LocalDate;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
public class BasicTypeToOdpsTypeTest {
+ public static FormatterContext defaultFormatterContext =
Review Comment:
Please update test case with default string format value.
##########
docs/en/connector-v2/sink/Maxcompute.md:
##########
@@ -112,6 +112,46 @@ Option introduction：
When data_save_mode selects CUSTOM_PROCESSING, you should fill in the
CUSTOM_SQL parameter. This parameter usually fills in a SQL that can be
executed. SQL will be executed before synchronization tasks.
+### datetime_format[Enum]
Review Comment:
Please update the docs too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
