DanielLeens commented on PR #10964: URL: https://github.com/apache/seatunnel/pull/10964#issuecomment-4591810032
Thanks for reorganizing the concerns here, and I appreciate the level of detail. These are thoughtful architecture questions, especially around how a Sink->Sink side channel relates to checkpoint alignment, backpressure propagation, and shared HZ operation threads. I want to be careful not to pretend a brand-new full Daniel re-review happened on the same unchanged head, though. The current PR head is still `5a789c128a387726aedc9972bc7aa37b217d3cbb`, which is the same revision I already re-reviewed on May 31. So my latest Daniel full-review conclusion on that exact head is still the same one from that review, rather than a newly expanded blocker list on the same code version. That said, I do think your discussion points are important input for the next revision. If the author decides to address them with either a design write-up or a code update, please push that as a new commit and I will re-review the latest head from scratch again against the full Zeta runtime path. Until then, from Daniel's side this stays in reply-only / awaiting-update state rather than a new full review on the unchanged head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
