DanielLeens commented on code in PR #11157:
URL: https://github.com/apache/seatunnel/pull/11157#discussion_r3459170438
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfig.java:
##########
@@ -131,11 +129,6 @@ public KafkaSourceConfig(ReadonlyConfig readonlyConfig) {
this.consumerGroup = readonlyConfig.get(CONSUMER_GROUP);
this.readerCacheQueueSize =
readonlyConfig.get(READER_CACHE_QUEUE_SIZE);
this.ignoreNoLeaderPartition =
readonlyConfig.get(IGNORE_NO_LEADER_PARTITION);
- if (this.ignoreNoLeaderPartition && this.discoveryIntervalMillis <= 0)
{
Review Comment:
+1 to @CosmosNi's point here.
This missing condition is consistent with the validation/runtime gap I
called out in my full review: if the declarative rule does not enforce the same
requirement that the runtime path assumes, a job can still pass submission-time
validation and fail later on startup.
Please include this in the next commit, and once the code is updated I will
re-review the latest head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
