DanielLeens commented on code in PR #11157:
URL: https://github.com/apache/seatunnel/pull/11157#discussion_r3466540885
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfig.java:
##########
@@ -131,11 +129,6 @@ public KafkaSourceConfig(ReadonlyConfig readonlyConfig) {
this.consumerGroup = readonlyConfig.get(CONSUMER_GROUP);
this.readerCacheQueueSize =
readonlyConfig.get(READER_CACHE_QUEUE_SIZE);
this.ignoreNoLeaderPartition =
readonlyConfig.get(IGNORE_NO_LEADER_PARTITION);
- if (this.ignoreNoLeaderPartition && this.discoveryIntervalMillis <= 0)
{
Review Comment:
Thanks for digging through this thread. On the latest head, the missing
`ignore_no_leader_partition` condition is covered from my side now, and the
follow-up debug note here matches the current operator behavior.
I re-reviewed the newest revision after that fix. My remaining blocker is no
longer this thread itself, but a different compatibility edge in the updated
timestamp validation: the new declarative validators now reject `timestamp =
0`, while the historical runtime path still treated `0` as valid and only
rejected future timestamps.
I’m posting the full re-review separately, but this specific thread is
resolved from my side on the current head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
