nzw921rx commented on code in PR #11157:
URL: https://github.com/apache/seatunnel/pull/11157#discussion_r3464126474
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfig.java:
##########
@@ -131,11 +129,6 @@ public KafkaSourceConfig(ReadonlyConfig readonlyConfig) {
this.consumerGroup = readonlyConfig.get(CONSUMER_GROUP);
this.readerCacheQueueSize =
readonlyConfig.get(READER_CACHE_QUEUE_SIZE);
this.ignoreNoLeaderPartition =
readonlyConfig.get(IGNORE_NO_LEADER_PARTITION);
- if (this.ignoreNoLeaderPartition && this.discoveryIntervalMillis <= 0)
{
Review Comment:
> if KEY_PARTITION_DISCOVERY_INTERVAL_MILLIS is null, does it mean
greaterThan never gets executed?
```java
// Numeric (null value -> false, preserving or() short-circuit)
m.put(
ConditionOperator.GREATER_THAN,
(v, c, cfg) -> v != null && compareNumbers(v,
c.getExpectValue()) > 0);
```
Good question, I have reconfirmed the operator processing logic. If it is
empty or less than or equal to 0, it will be rejected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
