nzw921rx commented on code in PR #11157:
URL: https://github.com/apache/seatunnel/pull/11157#discussion_r3459233952
##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaSourceConfig.java:
##########
@@ -131,11 +129,6 @@ public KafkaSourceConfig(ReadonlyConfig readonlyConfig) {
this.consumerGroup = readonlyConfig.get(CONSUMER_GROUP);
this.readerCacheQueueSize =
readonlyConfig.get(READER_CACHE_QUEUE_SIZE);
this.ignoreNoLeaderPartition =
readonlyConfig.get(IGNORE_NO_LEADER_PARTITION);
- if (this.ignoreNoLeaderPartition && this.discoveryIntervalMillis <= 0)
{
Review Comment:
> ```java
> KafkaSourceOptions.KEY_PARTITION_DISCOVERY_INTERVAL_MILLIS)
> Conditions.greaterThan(
>
KafkaSourceOptions.KEY_PARTITION_DISCOVERY_INTERVAL_MILLIS, 0L)
> ```
@DanielLeens thanks, Can you provide a detailed description of the missing
scene?
Here is the judgment logic in my PR submission：
```java
.conditional(
KafkaSourceOptions.IGNORE_NO_LEADER_PARTITION,
Boolean.TRUE,
KafkaSourceOptions.KEY_PARTITION_DISCOVERY_INTERVAL_MILLIS)
Conditions.greaterThan(
KafkaSourceOptions.KEY_PARTITION_DISCOVERY_INTERVAL_MILLIS, 0L))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
