goutamadwant commented on issue #9764:
URL: https://github.com/apache/seatunnel/issues/9764#issuecomment-5053280852

   Thanks @DanielLeens. I traced this against current `dev` through 
`ClientCommandArgs`, `ClientExecuteCommand`, `ClientJobExecutionEnvironment`, 
`MultipleTableJobConfigParser`, `SeaTunnelSourceCollector`, and 
`TransformFlowLifeCycle`.
   
   For the local-only first slice I plan to keep the implementation in these 
boundaries:
   
   - `ClientCommandArgs` accepts `--dry-run sample` and `--sample-limit` with a 
default of 10. Sample mode requires `--master local` and rejects async, 
restore, and savepoint paths.
   - `ClientExecuteCommand` passes an internal sample-mode flag and limit 
through `JobConfig`. Checkpointing is disabled and source parallelism is forced 
to 1, so the v1 limit is job-wide and deterministic.
   - `MultipleTableJobConfigParser` replaces configured sinks with an 
engine-owned preview sink before sink factory creation and save-mode handling. 
The configured sink plugin is not instantiated and no target-side write or DDL 
path is called.
   - `SeaTunnelSourceCollector` prints the source schema once, prints at most 
the configured rows, and signals normal source completion when the limit is 
reached.
   - `TransformFlowLifeCycle` prints each transform stage schema once and the 
corresponding bounded output rows.
   - Sink DDL preview stays out of this first PR. It will be reported as 
skipped until an opt-in preview SPI is agreed.
   
   Test plan:
   
   - CLI parsing, default/override limit, and invalid mode combinations
   - parser coverage proving configured sink factory and save-mode paths are 
not called
   - source collector coverage for exactly N rows and normal completion
   - source plus multi-transform output coverage
   - a local Fake source job confirming the preview exits and the configured 
sink receives no writes
   
   I will keep the draft PR limited to this slice.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to