DanielLeens commented on PR #11730:
URL: https://github.com/apache/seatunnel/pull/11730#issuecomment-5265834671

   Thanks @LeonYoah! Yeah, an all-key table (every column part of the 
primary/unique key, e.g. a composite-key junction table) is a legitimate but 
easy-to-miss schema shape — the `WHEN MATCHED THEN UPDATE SET` clause ends up 
with nothing to put in it, which is a straightforward SQL syntax error at write 
time.
   
   For anyone following along: this PR is at commit `c0824e0` (no new commits 
since my last review), it's already approved from my side with no open 
blockers, and the fork's `Build` check has since gone green on that commit too. 
So this looks ready to merge as-is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to