abolfazlmadanii commented on PR #11817: URL: https://github.com/apache/seatunnel/pull/11817#issuecomment-5301405599
After reviewing the connector again, I think a more conservative approach would be to first confirm the intended scope with the maintainers, or limit this PR to registering the missing options in `OptionRule`. The Email connector does not currently have an imperative SMTP-port validation to migrate, so the `email_smtp_port > 0` rule adds new validation behavior. Would you prefer that this PR keep the new constraint, or only add the missing options to `OptionRule`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
