abolfazlmadanii commented on PR #11817: URL: https://github.com/apache/seatunnel/pull/11817#issuecomment-5305674570
@goutamadwant Thanks for catching this. I addressed the unknown-key coverage gap in commit `188bd0c10`. The shared `EmailFactoryTest` validation helper now calls `ConfigValidator.validateUnknownKeys()` before `ConfigValidator.validate()`. Since `testExplicitOptionalOptions` explicitly configures `email_smtp_port`, `email_attachment_name`, and `email_field_delimiter`, removing any of those declarations from `OptionRule` will now fail the test and directly protect the CLI validation path that this PR fixes. Verification passed: - `./mvnw spotless:apply` - `./mvnw -pl seatunnel-connectors-v2/connector-email -DskipITs test` — 6 tests, 0 failures, 0 errors - `./mvnw -q -DskipTests verify` @DanielLeens, this also closes the remaining test-coverage item from your status summary. Could you please take another look when convenient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
