goutamadwant commented on PR #11817: URL: https://github.com/apache/seatunnel/pull/11817#issuecomment-5302442595
@abolfazlmadanii The option registration fix looks correct. I reproduced the original path with ConfigValidator.validateUnknownKeys(): without EMAIL_ATTACHMENT_NAME and EMAIL_FIELD_DELIMITER in OptionRule it fails with both reported as unknown keys, and with this change it passes. One test gap: EmailFactoryTest currently calls only ConfigValidator.validate(), which does not check unknown keys. The existing 5 tests still pass even if those two option declarations are removed. Could we update the test helper to run validateUnknownKeys() before validate()? That would directly cover the CLI validation failure this PR fixes and prevent the declarations from being removed accidentally later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
