abolfazlmadanii commented on PR #11817: URL: https://github.com/apache/seatunnel/pull/11817#issuecomment-5305615760
Thanks for the detailed review. I pushed commit `e9af64892` addressing the recommended changes: - validate the complete SMTP port range (`1..65535`); - add an inline comment explaining the fail-fast validation; - cover omitted optional options and their existing defaults; - cover explicitly configured optional options; - update the English and Chinese documentation to match the full port range. Local verification passed: - `./mvnw spotless:apply` - `./mvnw -pl seatunnel-connectors-v2/connector-email -DskipITs test` — 6 tests, 0 failures, 0 errors - `./mvnw -q -DskipTests verify` I have also updated the PR description to clarify that the SMTP port constraint is new fail-fast validation rather than a migration of an existing imperative check. Invalid port values previously failed later during email delivery. Could a maintainer please confirm whether keeping this validation in the scope of this PR is acceptable? @DanielLeens, could you please take another look at the updated changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
