DanielLeens commented on PR #11162: URL: https://github.com/apache/seatunnel/pull/11162#issuecomment-5363665772
Thanks @SEZ9 — that plan matches exactly what's needed. Just to confirm scope so there's no ambiguity when you push: 1. The Markdown fix only needs to touch the `### CDC Connector Changes` heading and the immediately preceding unrelated bullet in both `docs/en/introduction/concepts/incompatible-changes.md` and `docs/zh/introduction/concepts/incompatible-changes.md` — restore the un-indented bullet, drop the heading's leading space, and add the blank line before it. No other content in that file needs to change. 2. On the CI flake: if a rerun of `mysql-cdc-connector-it (11, ubuntu-latest)` comes back clean with no source change, that's sufficient evidence it was infrastructure timing and not a STRICT-policy defect — you don't need to chase a source fix in that case, just note the clean rerun when you ping me. If it fails again with the same "still threads running in the container" pattern, then it's worth widening the Awaitility window or looking at the HikariPool teardown timing in that test. I'll hold off on a new review pass until both land on the same head (or until you've confirmed the rerun is clean with no code change needed) — no need to ping me for the doc fix alone if the E2E test is still red, since I'll want to look at both together. Thanks for staying on top of this through every round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
