SEZ9 commented on PR #11162: URL: https://github.com/apache/seatunnel/pull/11162#issuecomment-5358315154
Thanks @DanielLeens for another rigorous from-scratch pass on `80c35cc6d5` — especially the care in diffing each commit against its own merge-base with `dev` to cleanly separate PR-owned changes from rebase drift. That confirms what we'd hope: the logic I understood you to approve on `3853574200` (the shared `overridesDeprecatedSchemaChangeMethod` in `SchemaChangePolicy.java`, the deduplicated `MultiTableSinkWriter.java`, the guarded throw in `SinkFlowLifeCycle.java`, and the identical `FlinkSinkWriter.java` fix in both modules) is byte-for-byte unchanged on the current head, with only line-number shifts from unrelated `dev` code. Agreed that the two new items you flagged are real and blocking: 1. **Docs conflict-resolution artifact** — the Markdown-formatting defect in `docs/en/introduction/concepts/incompatible-changes.md` and its `zh` counterpart is clearly a rebase artifact, not intentional. I'll fix both files and re-verify they render correctly. 2. **Red CI on the STRICT-behavior E2E test** — since this is the PR's own new test failing on this exact head, I'll dig into whether the rebase changed the environment the test assumed or whether it's flaky, and won't ask for re-review until it's green. Concretely, remaining asks on my side before requesting your next look: - Push a fix for the Markdown artifact in both the `en` and `zh` incompatible-changes docs. - Get CI green on the new STRICT E2E test on the same head, and confirm no further PR-owned delta beyond those two fixes. I'll ping you here once both are done. Thanks again for holding the line on approving only a green, clean head — that's exactly right for a change touching the schema-evolution contract across the source, coordination, and sink-apply gates. <!-- streview-comment:398 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
