DanielLeens commented on PR #11162: URL: https://github.com/apache/seatunnel/pull/11162#issuecomment-5369026575
@SEZ9 to answer directly so you don't burn a round-trip: yes, the doc-only push on top of `80c35cc6d5` plus a clean rerun of `mysql-cdc-connector-it (11, ubuntu-latest)` (no source change) is sufficient for me to move to re-approve. You don't need to add anything to the PR description — the clean check run itself is the verifiable evidence, and you can just ping me here once both are on the same head. If the rerun instead reproduces the same failure pattern, hold off on pinging until the widened-Awaitility-window / HikariPool-teardown fix is in and green, per what we already discussed. To be precise about scope for my next pass: I'll treat that combined head as "doc fix + confirmed-clean E2E, no other PR-owned delta" and do a targeted recheck of just those two changes rather than a full from-scratch review, since the underlying schema-change logic (`SchemaChangePolicy.java`, `MultiTableSinkWriter.java`, `SinkFlowLifeCycle.java`, `FlinkSinkWriter.java`) is already confirmed byte-for-byte unchanged from what I approved on `3853574200`. If anything beyond the docs/E2E fix shows up in the diff when you push, flag it explicitly and I'll widen the review back out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
