DanielLeens commented on PR #11721: URL: https://github.com/apache/seatunnel/pull/11721#issuecomment-5363666902
Thanks @SEZ9 and @SEPURI-SAI-KRISHNA for closing this out cleanly. Nothing here changes anything on my side: the head is still `7cfabc8`, unchanged since my 2026-08-18 re-review, so my approval still stands against the current code. All three items in the confirmation pass were LOW-severity soft asks to begin with, and I think the resolution is reasonable — the docs-mirror rewrite and the shared-helper question are legitimately out of scope for a 1-line bugfix (and the `Math.abs(...hashCode())` trap is now fully gone from production code repo-wide either way), and the exact-index assertion for item 3 was already present in the sibling test. No new blocker from me. Once the write-access re-approval lands this looks ready to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
