SEZ9 commented on PR #11721: URL: https://github.com/apache/seatunnel/pull/11721#issuecomment-5385642676
Thanks @SEPURI-SAI-KRISHNA — you're right, and apologies for the noise. My latest pass evidently re-ran against the pre-resolution finding list rather than the state after my 2026-08-21 comment. Confirming both items here so the thread record is unambiguous: **F1 (docs snippet divergence):** Resolved via the agreed deferral. The ask was to file and link the follow-up, and you did exactly that — #11923 is filed and linked, and #11925 goes further by actually rewriting the block (`element.getField(primaryKey.get())` / `% blockingQueues.size()`, relabelled as simplified rather than class source). That satisfies the condition I set — a tracked rewrite that stops the block claiming to be the real implementation. Please **don't** push the interim "simplified pseudo-code" label here: it would be deleted by #11925 within a PR or two and would dismiss @DanielLeens's approval for something cosmetic. Your scoping call is the right one. **F2 (shared non-negative-mod helper):** Withdrawn, and it stays withdrawn. Nothing changed since — your call-site survey still holds, and the `(hash & Integer.MAX_VALUE) % n` idiom in this PR is the established pattern. DanielLeens's re-review of the test-strengthening commit `11599d94d` also independently verified the arithmetic (`Integer.MIN_VALUE & Integer.MAX_VALUE == 0`), which is exactly the reassurance a helper would have been meant to provide. **Remaining asks:** none blocking on this PR from my side. Two small housekeeping items: (1) once this merges, please rebase #11925 if needed so the docs rewrite lands cleanly; (2) if the apache-side CI failure DanielLeens flagged turns out to be infra flake, a re-trigger note in the thread would be helpful for the record. Thanks for the patient, well-evidenced write-up — this is how deferrals should be handled. <!-- streview-comment:483 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
