SEZ9 commented on PR #10472: URL: https://github.com/apache/seatunnel/pull/10472#issuecomment-5381235170
Thanks @DanielLeens — glad the SAP HANA CHAR clarification landed. To confirm: we're aligned that `CHAR`/`VARCHAR` stay on the raw-length path (single-byte ASCII semantics in this mapping) while the x4 Unicode conversion remains limited to `NVARCHAR`/`SHORTTEXT`, so no further changes are needed on the `convert()` side. I'll treat the source-review question as resolved by that clarification. On the remaining blocker, I agree with your assessment and the sequencing you proposed. The failing signals in the run you referenced (https://github.com/dik111/seatunnel/actions/runs/30203290621/job/89797481903) are outside the SAP HANA CHAR mapping path, and the branch being far behind `dev` makes it premature to ask for fixes to unrelated engine or integration-test failures in this PR. Concrete remaining asks: 1. Sync this branch with the latest `dev` and push the updated head. 2. Rerun `Build` on the synced branch. 3. If `Build` still fails after the sync, share the new failing check link so we can narrow it down against the updated head — @DanielLeens has offered to help with that triage. Once the branch is synced and CI is green, this should be ready to move forward per @davidzollo's earlier approval conditioned on CI passing. <!-- streview-comment:441 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
