SEZ9 commented on PR #10472: URL: https://github.com/apache/seatunnel/pull/10472#issuecomment-5409363722
Thanks @DanielLeens — confirming we're fully aligned, and nothing on that comment is left unanswered from my side: 1. Source review is settled: `CHAR`/`VARCHAR` stay on the raw-length path and the x4 Unicode conversion remains limited to `NVARCHAR`/`SHORTTEXT`. No further changes to `convert()` are needed. 2. On CI: agreed the failures on the current stale head (run 30203290621, job 89797481903) look unrelated to this mapping change, and @davidzollo's approval is explicitly conditional on `Build` passing. Nothing is done yet on the gating side because the branch head hasn't moved. The concrete remaining ask is on the contributor: please sync the branch with the latest `dev`, push the updated head, and rerun `Build`. Once that lands, your plan for a fresh full pass against the synced head sounds right — and please do flag it if the merge shifts anything around `convert()` so we can re-check that spot together. If `Build` still fails after the sync, share the new failing run link and we'll narrow it down against the updated head. <!-- streview-comment:538 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
