DanielLeens commented on PR #10472: URL: https://github.com/apache/seatunnel/pull/10472#issuecomment-5385664473
Thanks @SEZ9, that summary matches where I landed too. To confirm the current state clearly for @dik111: 1. Source-review side is settled: `CHAR`/`VARCHAR` stay on the raw-length path since SAP HANA treats them as single-byte ASCII, and the x4 Unicode conversion stays limited to `NVARCHAR`/`SHORTTEXT`. No further changes needed on `convert()`. 2. The only remaining gate is CI/merge mechanics: the branch head is still unchanged and far behind `dev`, so the failing checks are very likely stale/unrelated rather than something to patch inside this SAP HANA diff. Next concrete step is still on the branch owner's side: sync with the latest `dev`, push the updated head, and rerun `Build`. Once that lands I'll do a fresh full review pass against the synced head (not just re-check CI), since a merge with `dev` could shift line numbers or touch adjacent code. Happy to help narrow down any new failure once the updated head is available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
