zhang-arvin commented on PR #11866: URL: https://github.com/apache/seatunnel/pull/11866#issuecomment-5453985104
@DanielLeens @SEZ9 Thanks for the thorough reviews and patience! I have addressed all the issues: **1. Removed unrelated docs**: The ~828 lines of Zeta tuning-guide documentation have been removed. The PR now contains only the JDBC driver conflict fix. **2. Added `acceptsURL()` exception handling**: Both `AbstractJdbcCatalog.getConnection()` and `SimpleJdbcConnectionProvider.getOrEstablishConnection()` now wrap `driver.acceptsURL()` in try-catch. If `acceptsURL()` throws `SQLException`, the driver is skipped (in `AbstractJdbcCatalog`) or falls back to `DriverManager.getDriver()` (in `SimpleJdbcConnectionProvider`). **3. Test improvements**: `SimpleJdbcConnectionProviderTest` now asserts URL acceptance behavior with proper mock setup. Please take another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
